-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(optimizer): support glob includes #12414
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Nice! Looks good to me. Added the PR to the team board with P2-5 so we get to it in the next meeting. |
Added docs and mention that it's experimental. Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge this one after resolving the conflicts @bluwy
The CI fail seems to be flaky and unrelated as it happens for other PRs too. It likely happen more often since #13413 (even though the PR is a good refactor). I'm thinking we could merge this for now and tackle that separately (which I'm checking now). Alas I can't merge without an approving review 😅 |
Description
Close #5419
Support
optimizeDeps.include: ['some-pkg/**/*', 'another-pkg/*.js', ...]
syntax. While the user could glob themselves, this PR also handles the complex logic of globbing packages withexports
.Besides the issue above, I had found in Svelte land where this could be useful for component libraries that heavily rely on deep imports. Being able to optimize all deep imports at once would be helpful.
Additional context
The test could be a lot more complete, but it got a minimum to start with
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).