-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-vite): use typescript 5.0 in templates #12481
Conversation
`--forceConsistentCasingInFileNames` is no longer necessary
Run & review this pull request in StackBlitz Codeflow. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, the tsconfig in vite package could not use moduleResolution: "bundler"
for these reasons:
ufo
does not ship atypes
field inexports
, they had added it https://github.com/unjs/ufo/blob/main/package.json#L10 and I believe it gonna be published in days.@ampproject/remapping
relies on an old version of@jridgewell/gen-mapping
which does not provide correctexports.types
. The source code has been updated but not published. I filed an issue to track this Considering publish a new version to NPM? ampproject/remapping#184api-extractor
somehow seems like do not recognizebundler
for now and will throw an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this, then merge #12604
Description
TypeScript 5.0 has been released with standard decorator support and various config improvements, notably including
--moduleResolution bundler
which is recommended by Evan You and Daniel Rosenwasser for Vite users.Additional context
Note that due to TypeScript not following semver, 4.9 and 5.0 are both releases with breaking changes, so this upgrade should be roughly as compatible as previous major and minor upgrades.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).