Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esbuild complains with extra fields #12516

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Mar 21, 2023

Description

Partial revert of #12493
Thanks @sapphi-red for spotting the issue in ecosystem-ci

Projects in the ecosystem are also passing an ESBuildOptions object so we need to keep these guards to make esbuild happy.

Note: esbuild also complains if setting include: undefined in the object.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Mar 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Mar 21, 2023

📝 Ran ecosystem CI: Open

suite result
astro ❌ failure
histoire ❌ failure
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ❌ failure
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ❌ failure
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev patak-dev added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Mar 21, 2023
@sapphi-red
Copy link
Member

The ecosystem-ci run with #12493: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/4481055968.

astro, iles, ladle, nuxt was previously failing with Invalid option in transform() call: "include".

iles, ladle is passing now. astro is failing with a known flaky (?) error.
nuxt is failing with a different error.
plugin-react is somehow failing but I don't think this PR is related.

Note that histoire is failing with the PluginContextMeta error both before and after.

@patak-dev patak-dev merged commit 7be0ba5 into main Mar 21, 2023
@patak-dev patak-dev deleted the fix/esbuild-complains-with-extra-fields branch March 21, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants