fix(create-vite): skip lib check in tsconfig templates #12591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When type checking configs using
npx tsc --project tsconfig.node.json --noEmit
, eg. in CI, there are a number of failures fromnode_modules
types (see output below).This PR sets
"skipLibCheck": true"
in all TS templates with the extra Node.jstsconfig
to avoid this.Additional context
I changed all files that I saw in the templates, but if there are any others that I should change, happy to do so.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).