Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(html): apply preTransformRequest for html scripts #12599

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 26, 2023

Description

When handling URLs for <script type="module">, also pretransform their requests. This should speed up startup time a little.

Additional context

An interesting side effect with this is that, if someone calls server.transformIndexHtml manually (custom server), this would start pre-transforming things. Maybe that's a good thing 🤔


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added feat: html performance Performance related enhancement labels Mar 26, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Mar 26, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ❌ failure
iles ❌ failure
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member

When using transformIndexHtml during Dev SSR, this will kick start the client processing. I think this makes sense also for this case. If ecosystem-ci is happy, I think we should try this during the beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants