Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: cache depsCacheDirPrefix value for isOptimizedDepFile #12601

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

sapphi-red
Copy link
Member

Description

isOptimizedDepFile was calling getDepsCacheDirPrefix every time.
So normalizePath and path.resolve was called every time.
Also this potentially causes gc as many string will be created.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the performance Performance related enhancement label Mar 26, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Nice!

@patak-dev patak-dev merged commit edbd262 into vitejs:main Mar 26, 2023
@sapphi-red sapphi-red deleted the perf/create-is-optimized-dep-file branch March 26, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants