-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After Vite 4.2 upgrade, the manifest.json file cannot be generated after using sharedwork #12627
Comments
Start a new pull request in StackBlitz Codeflow. |
It seems there is an issue with Workers with latest version of vite, reference to another Web Worker issue – #12611 (comment) |
Duplicate of #10190 |
@sun0day It seems there's a race condition. |
Hey @sun0day I tested with the latest 4.3.0-beta.1 still exist. When I was debugging, I found that the emitFile in the manifest.ts is triggered the output of manifest.json twice. Once it output the content of the file we saw below:
and the second time it output the content of assets, but it was not written to the file. So should it output 2 manifest.json files or should it be combined into one file for output. |
Describe the bug
After Vite 4.2 upgrade, the manifest.json file cannot be generated after using sharedwork
Only show so few assets lines:
It seems that Rollup has change the method finalizeAdditionalAsset.
rollup/rollup@75c5113#diff-016e61f8e680c4307db5ae6252b432289d01f2d31802ce47892a9b832cd6abc2R398-R400
Reproduction
https://stackblitz.com/edit/vitejs-vite-jb9po3?file=main.js&terminal=dev
Steps to reproduce
After run build, check the manifest.json file in the dist directory
System Info
Used Package Manager
npm
Logs
No response
Validations
The text was updated successfully, but these errors were encountered: