Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): correctly handle warning ignore list #12831

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix(build): correctly handle warning ignore list #12831

merged 1 commit into from
Apr 11, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 11, 2023

Description

ref #12757

I think the condition check is inverted, otherwise we only log warnings that are [CIRCULAR_DEPENDENCY, THIS_IS_UNDEFINED]

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 11, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Boolean conditions are the hardest 🤦🏼

@patak-dev patak-dev merged commit 8830532 into main Apr 11, 2023
@patak-dev patak-dev deleted the fix-vite-warn-check branch April 11, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @patak-dev