fix: unwrapId and pass ssr flag when adding to moduleGraph in this.load #13083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@gajus, a shot in the dark, but you could try if you have some time. I think the issue may be elsewhere though. |
patak-dev
added
the
p3-minor-bug
bluwy
approved these changes
May 4, 2023
patak-dev
deleted the
fix/unwrap-id-before-adding-to-module-graph-in-this-load
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found while checking #13030. It may be a possible cause of the issue if Playwright started using the
this.loadfunction with virtual modules in dev mode.We should do the same as we are doing here:
What is the purpose of this pull request?