-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create-vite): use "target": "ES2020"
in React template
#13147
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@ArnaudBarre I found other templates uses |
This is clearly is mistake, it should be ES2020 (for lib, the others are mostly decorative given that this is configured in Vite) + useDefineForClassFields |
Ah my bad 😅 |
Wait, so target should remain as ESNext? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah "module" doesn't bring much and Vite will jump on the new features when they arrive for that so I think this good like this
useDefineForClassFields
in React template"target": "ES2020"
in React template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating!
Description
Unless I am mistaken, I think this flag was unintentionally dropped in #12604 (cc @ArnaudBarre). This PR restores it for consistency with the other templates.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).