Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import public non-asset URL #13422

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 4, 2023

Description

Add support for import '/foo.json?url' (foo.json is in public directory) and improve errors for importing .json in public directory.

behavior after this PR behavior before this PR
import foo from '/public/foo.json' warning (foo is the content of foo.json) warning (foo is the content of foo.json)
import foo from '/public/foo.json?url' warning (foo is the URL of foo.json) warning (foo is the URL of foo.json)
import foo from '/foo.json' error error
import foo from '/foo.json?url' no error (foo is the URL of foo.json) error

close #13284

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Jun 9, 2023
patak-dev
patak-dev previously approved these changes Jun 9, 2023
@patak-dev patak-dev dismissed stale reviews from bluwy and themself via 88192c9 June 9, 2023 09:24
@patak-dev patak-dev merged commit 3a98558 into vitejs:main Jun 9, 2023
@sapphi-red sapphi-red deleted the feat/public-non-asset-url branch June 9, 2023 16:06
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added "Turn off public JavaScript reference hints"
3 participants