Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show network URLs when --host 0.0.0.0 #13438

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: show network URLs when --host 0.0.0.0 #13438

merged 1 commit into from
Jun 6, 2023

Conversation

sapphi-red
Copy link
Member

Description

The "Network: http://192.168.0.1:5173/" wasn't shown when --host 0.0.0.0 is passed.
This PR fixes this regression caused by #13412.

https://discord.com/channels/804011606160703521/1115146467502461019/1115565872430448650

refs #13412

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Jun 6, 2023
@sapphi-red sapphi-red added this to the 4.4 milestone Jun 6, 2023
@stackblitz
Copy link

stackblitz bot commented Jun 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member Author

/ecosystem-ci run astro

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Jun 6, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
astro ✅ success

@patak-dev patak-dev merged commit 00ee8c1 into vitejs:main Jun 6, 2023
@sapphi-red sapphi-red deleted the fix/show-network-urls-when-host-0 branch June 7, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev