-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: use thread for preprocessors #13584
perf: use thread for preprocessors #13584
Conversation
Run & review this pull request in StackBlitz Codeflow. |
66a0c9e
to
6d45801
Compare
The implementation should be fine now. The edge cases are now handled. I think there's three points that needs to be discussed.
I tested the PR with some project/reproductions.
I didn't test with less/stylus because I didn't find a project that uses less or stylus and not small. Footnotes |
/ecosystem-ci run |
📝 Ran ecosystem CI on
|
Finally finished this PR 😅 Added an experimental |
This is awesome! |
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
Description
This is just a POC yet. I need to polish the code and handle some edge cases (For example, when
options.importer
is used).Running Vite on my project1 with this PR reduces the build time from 11.04s to 9.43s.
I made a PR with CSS preprocessors, but in theory this technique would be effective in the following case:
I guess this can be applied to plugin-vue and plugin-react too.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).Footnotes
https://github.com/traPtitech/traQ_S-UI, removed PWA plugin and brotli plugin (as they take some time) ↩