-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export server.bindCLIShortcuts
#13675
Conversation
Run & review this pull request in StackBlitz Codeflow. |
cc @bluwy this makes changing the behaviour of rawMode a lot more breaking. But that's fine if we change this only in Vite 5. The printHelp option was there from the beginning to make this customisable later when using the JS API |
Should it be a method in |
Yeah making it |
bindShortcuts
from vite/node
server.bindCLIShortcuts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for spotting the meeting notes and making the changes. We forgot to leave a comment about it 😅
hey folks, apologies for this kind of question, but I'm unfamiliar with the release scheduling for Vite and I wasn't able to dig up (or missed) the docs around it. Is there any info that outlines when we could expect to see this released? |
We haven't made a release this week. I'll skim through some PRs to merge and cut a new release today. The next version should be 5.0.0-beta.1 |
Description
When i use
createServer
(Node API), expect to use keyboard shortcuts. can it export?node/index.ts
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).