Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(legacy): add guard to modern polyfill chunk #13719

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix(legacy): add guard to modern polyfill chunk #13719

merged 2 commits into from
Sep 20, 2023

Conversation

lsdsjy
Copy link
Contributor

@lsdsjy lsdsjy commented Jul 5, 2023 •
edited
Loading

Description

Modern polyfills should not run on legacy targeted browsers.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@lsdsjy lsdsjy marked this pull request as draft July 6, 2023 11:38
@lsdsjy lsdsjy marked this pull request as ready for review July 28, 2023 03:16
@sapphi-red sapphi-red added plugin: legacy p3-minor-bug An edge case that only affects very specific usage (priority) labels Aug 21, 2023
@bluwy bluwy merged commit 945dc4d into vitejs:main Sep 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsdsjy @bluwy @sapphi-red