-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terser): add maxWorkers
option for terserOptions
#13858
feat(terser): add maxWorkers
option for terserOptions
#13858
Conversation
Run & review this pull request in StackBlitz Codeflow. |
maxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-terser
maxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-tersermaxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-terser
maxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-tersermaxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-terser
Please help me review this PR @sapphi-red , thank you ❤️ |
Hi @patak-dev , please help me review this issue and this PR , thank you 💟 |
Could you help me take a look at this PR please @bluwy ❤️ ? |
@sangquangnguyen thanks for the PR! Please be more patient next time, it is completely normal that a PR or issue will take a couple of days to be reviewed/triaged. Notifying maintainers only generates more notifications for everybody, and it may make them less willing to engage. I think we should add this feature. And reusing |
Cool, I will be more patient next time, thank @patak-dev for your reply and also your great advice. Have a nice day ;) |
I also think this is a nice feature to add. I wonder if we ever go forward with #13584, maybe we can have a single top level config to control the max threads instead. |
maxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-tersermaxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-terser
maxWorkers
for terserOptions support as rollup-plugin-terser and @rollup/plugin-tersermaxWorkers
option for terserOptions
maxWorkers
option for terserOptionsmaxWorkers
option for terserOptions
Merging as we already have approval from the last meeting. |
Thanks team, love 💓 |
Description
Closes #13856
Additional context
Take a look at 2 repos
@rollup/plugin-terser supports maxWorkers
rollup-plugin-terser supports numWorkers
They are supporting
maxWorkers
property for customizing the worker when running terser minify.I encountered 137 error (Out of Memory) in CI build because of that. So allow custom the worker pool is the best solution
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).