Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): upgrade rollup to 3.28.0 #14049

Merged
merged 2 commits into from
Aug 9, 2023
Merged

feat(deps): upgrade rollup to 3.28.0 #14049

merged 2 commits into from
Aug 9, 2023

Conversation

sapphi-red
Copy link
Member

Description

This PR simply upgrades rollup to 3.28.0.

By doing this, we can rely on preliminaryFileName in #11671 and #13974.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Aug 9, 2023
@stackblitz
Copy link

stackblitz bot commented Aug 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red mentioned this pull request Aug 9, 2023
Merged
9 tasks
bluwy
bluwy approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 cc @thebanjomatic from #14016 (comment)

@patak-dev patak-dev merged commit 490dad8 into vitejs:main Aug 9, 2023
12 checks passed
@sapphi-red sapphi-red deleted the feat/rollup-3.28 branch August 9, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphi-red @bluwy @patak-dev