fix!: avoid rewriting this (reverts #5312) #14098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12340
Description
This PR reverts #5312. As it was discussed in #12340, Vite shouldn't be replacing
this
in an ESM context.@ArnaudBarre, #5312 was intended to avoid
THIS_IS_UNDEFINED
warnings in React apps, but we're already ignoring this warning here:vite/packages/vite/src/node/build.ts
Line 876 in 63a4451
If there is a warning or error in source maps to be avoided though, we should fix it without the need for this rewrite.
As proposed by @bluwy, we can merge this in Vite 5 as it is a breaking change.
What is the purpose of this pull request?