-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add extension to internal virtual modules #14231
feat!: add extension to internal virtual modules #14231
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is a good idea to wait until ecosystem-ci is green to be able to do a run with this PR properly.
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
I guess nuxt is failing because of this line: https://github.com/nuxt/nuxt/blob/f000e8b605c3702882310ee7b3925233c83ace98/packages/vite/src/plugins/chunk-error.ts#L8 Other fails are the same with the main branch. |
Description
Adds the extension (
.js
) to internal virtual modules (e.g.vite/modulepreload-polyfill
)close #9016
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).