Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace duplicate code with tryStatSync #14461

Merged
merged 3 commits into from
Sep 25, 2023
Merged

refactor: replace duplicate code with tryStatSync #14461

merged 3 commits into from
Sep 25, 2023

Conversation

Plumbiu
Copy link
Contributor

@Plumbiu Plumbiu commented Sep 25, 2023

Description

Some code is duplicated with the tryStatSync function.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Sep 25, 2023
sapphi-red
sapphi-red requested changes Sep 25, 2023
View reviewed changes
packages/vite/src/node/packages.ts Outdated Show resolved Hide resolved
@sapphi-red sapphi-red changed the title style: replace duplicate code with tryStatSync refactor: replace duplicate code with tryStatSync Sep 25, 2023
@bluwy bluwy merged commit be6b0c8 into vitejs:main Sep 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Plumbiu @bluwy @sapphi-red