feat(ssr): backport ssr.resolve.conditions and ssr.resolve.externalConditions (#14498) #14668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lConditions options (#14498)
bluwy
approved these changes
Oct 17, 2023
sapphi-red
approved these changes
Oct 17, 2023
| const resolveOptions: InternalResolveOptions = { | ||
| ...config.resolve, | ||
| root, | ||
| isProduction: false, | ||
| isBuild: true, | ||
| conditions: targetConditions, |
There was a problem hiding this comment.
This line can be thought as a breaking change (previously resolve.conditions were used, but now ssr.resolve.externalConditions will be used). But I guess it wouldn't cause any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #14498 to v4. We can discuss here if we should move forward with it. We can release it under a v4 minor if we merge it. A few downstream projects awaiting this feature: #14498 (comment)
What is the purpose of this pull request?