Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a runtime warning for the old object type transformIndexHtml hook #14791

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 29, 2023

Description

The old object type transformIndexHtml hook was deprecated in Vite 4. But didn't have a runtime warning.

I considered removing this in Vite 5, but it was still used in many places.

refs #9669

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 29, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 17fb5ee into vitejs:main Oct 29, 2023
13 checks passed
@sapphi-red sapphi-red deleted the runtime-warning-for-old-transform-index-html-object-type branch October 30, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants