Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade rollup to 4.2.0 and use parseAstAsync #14821

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: upgrade rollup to 4.2.0 and use parseAstAsync #14821

merged 2 commits into from
Oct 31, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 31, 2023 •
edited
Loading

Description

Upgrades rollup to 4.2.0 and pulls in the perf improvements.

refs rollup/rollup#5202

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 31, 2023
@stackblitz StackBlitz
Copy link

stackblitz bot commented Oct 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy merged commit 86a5356 into vitejs:main Oct 31, 2023
11 checks passed
@sapphi-red sapphi-red deleted the feat/rollup-4.2 branch October 31, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @bluwy