fix: use latest module graph in transform middleware #14892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In SSR, when restarting the server, the transform middleware may still be referring to the old module graph causing a
ERR_CLOSED_SERVER
504 error whenever we trying to fetch/@vite/client
again. Even though Vite restarts the server with new middlewares, middlewareMode will always only use the original middlewares:vite/playground/ssr/server.js
Lines 23 to 42 in fc24b07
Additional context
I tested this in the
ssr
playground. You can start the server, open the page to see it work. Then updatevite.config.js
(a few times), then refresh the page. You'll see it failed to fetch the requests.However, I can't seem to properly test this. The logs aren't predictable for some reason.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).