Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip initial clear screen if has logs #14936

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 10, 2023

Description

fix #9378

Don't clear the initial startup if have existing logs. This makes logger.hasWarned no longer used, but we could probably remove that in the next major if it's no longer useful.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 10, 2023
@patak-dev patak-dev merged commit a92bc61 into main Nov 10, 2023
10 checks passed
@patak-dev patak-dev deleted the no-clear-if-write branch November 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clearScreen: 'update'
2 participants