Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update es-module-lexer to 1.4.0 #14937

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

sapphi-red
Copy link
Member

Description

This PR updates es-module-lexer to 1.4.0 and removes a workaround introduced in #9314.
Also uses the newly introduced ParseError type instead of any.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Nov 10, 2023
@patak-dev
Copy link
Member

We can do this in another PR, but would the trimWhitespaceAndComments step in #14910 still be needed after es-module-lexer is updated?

patak-dev
patak-dev previously approved these changes Nov 10, 2023
@sapphi-red
Copy link
Member Author

IIUC we can remove that part as well. Removed 👍

@patak-dev patak-dev enabled auto-merge (squash) November 10, 2023 08:06
@patak-dev patak-dev merged commit 374e6fd into vitejs:main Nov 10, 2023
10 checks passed
@sapphi-red sapphi-red deleted the refactor/update-es-module-lexer branch November 10, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants