Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: point links in messages at https: #14992

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

tomayac
Copy link
Contributor

@tomayac tomayac commented Nov 15, 2023

Description

This saves users one redirect from http: to https: when they paste any of the "See https://vite.dev…" links logged to the console into their browser.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update (in the broader sense)
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@tomayac tomayac changed the title Point links in messages at https: docs: Point links in messages at https: Nov 15, 2023
@tomayac tomayac changed the title docs: Point links in messages at https: docs: point links in messages at https: Nov 15, 2023
@tomayac tomayac marked this pull request as draft November 15, 2023 11:06
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like GitHub is having issues causing CI to fail

@tomayac tomayac marked this pull request as ready for review November 15, 2023 11:17
@tomayac
Copy link
Contributor Author

tomayac commented Nov 15, 2023

LGTM. Seems like GitHub is having issues causing CI to fail

Aaah, and there I was scratching my head and trying all over with StackBlitz, which also got stuck. Thanks for the LGTM. Marked this as ready for review then, now knowing that it's not me, but GitHub… ;-)

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit d3af879 into vitejs:main Nov 15, 2023
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants