Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sirv needs to be upgraded to 2.0.4 to fix javascript mimetype #15398

Closed
7 tasks done
benmccann opened this issue Dec 20, 2023 · 0 comments · Fixed by #15427
Closed
7 tasks done

sirv needs to be upgraded to 2.0.4 to fix javascript mimetype #15398

benmccann opened this issue Dec 20, 2023 · 0 comments · Fixed by #15427
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Comments

@benmccann
Copy link
Collaborator

Describe the bug

sirv is serving .js and .mjs files as application/javascript instead of the standardized text/javascript

I would send a PR to upgrade sirv myself, but it's patched and I don't quite understand the patching processed used here

Reproduction

"sirv@2.0.3": "patches/sirv@2.0.3.patch",

Steps to reproduce

No response

System Info

`main`

Used Package Manager

pnpm

Logs

No response

Validations

@benmccann benmccann added bug p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Dec 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant