Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract '_metadata.json' string to a constant #15541

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

jh-leong
Copy link
Contributor

@jh-leong jh-leong commented Jan 8, 2024

Description

This PR addresses code maintainability by extracting the repeated string _metadata.json into a constant named METADATA_FILENAME.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Jan 8, 2024
@bluwy bluwy merged commit adda370 into vitejs:main Jan 10, 2024
10 checks passed
@jh-leong jh-leong deleted the refactor/extract_string branch January 12, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants