-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: normalize cache package dir #15546
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Is there a reason to do so? It's going to affect this: vite/packages/vite/src/node/packages.ts Lines 47 to 49 in 2836276
There's also code that will normalize it later: vite/packages/vite/src/node/plugins/resolve.ts Lines 930 to 939 in 2836276
|
I think it will be good to move to normalizing all paths in our (resolved) configs and public APIs. We have a confusing situation right now with some paths normalized and others that aren't. It would also be good to define a standard regarding trailing slashes for directories. |
I just think it's better to keep all path information formatted consistent. I did forget to edit it here, I will add it.
It certainly seems so. However, as in the picture I provided, when debug information is output, the path at this time is not normalized. |
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).