fix: revert package.json change should trigger server restart (#15519)
#15558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 260ebbf.
|
|
bluwy
previously approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 260ebbf.
Description
@btea, we discussed in today's team meeting and decided to revert this change for now as the extra server start when modifying something that isn't the field type is a DX regression.
We can keep discussing in #15543 if we should add a check for the main package.json and restart the server in case the change would affect the way the config file is loaded. I'm leaning towards documenting that changes in the package.json structure in the project requires a hard restart though.
What is the purpose of this pull request?