fix(hmr): propagate fs.stat failure for hmrContext.read
#15568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an unhandled promise rejection that could occur if a file disappeared during the polling period inside `readModifiedFile` (aka `hmrContext.read`). This unhandled rejection would cause the vite server to crash.
|
|
bluwy
approved these changes
Jan 11, 2024
bluwy
changed the title
fs.stat failure for hmrContext.readfs.stat failure for hmrContext.read
patak-dev
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an unhandled promise rejection that could occur if a file disappeared during the polling period inside
readModifiedFile(akahmrContext.read). This unhandled rejection would cause the vite server to crash.What is the purpose of this pull request?