Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await configResolved hooks of worker plugins #15597

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix: await configResolved hooks of worker plugins #15597

merged 2 commits into from
Jan 15, 2024

Conversation

aleclarson
Copy link
Member

Description

The configResolved hook should always be awaited, but it's not for worker plugins. This is the cause of a bug in vite-tsconfig-paths for Vite 5 users.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@aleclarson aleclarson mentioned this pull request Jan 13, 2024
Closed
ArnaudBarre
ArnaudBarre reviewed Jan 14, 2024
View reviewed changes
Copy link
Member

@ArnaudBarre ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running prettier should makes it easier to review

@aleclarson aleclarson force-pushed the fix/await-worker-plugin-configResolved branch from e741b0b to 617cd6a Compare January 14, 2024 21:54
@aleclarson
Copy link
Member Author

@ArnaudBarre Good point, thanks!

@patak-dev patak-dev enabled auto-merge (squash) January 15, 2024 09:46
@patak-dev patak-dev merged commit 03c8004 into vitejs:main Jan 15, 2024
10 checks passed
patak-dev pushed a commit that referenced this pull request Jan 15, 2024
@aleclarson @patak-dev
fix: await configResolved hooks of worker plugins (#15597)
a44bce8
@patak-dev patak-dev mentioned this pull request Jan 15, 2024
Merged
4 tasks
@patak-dev
Copy link
Member

Thanks Alec! Ported it to 5.0 here #15605

@patak-dev patak-dev added regression The issue only appears after a new release p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 15, 2024
patak-dev added a commit that referenced this pull request Jan 18, 2024
@patak-dev @aleclarson
fix: await configResolved hooks of worker plugins (#15597) (#15605)
ef89f80 
Co-authored-by: Alec Larson <1925840+aleclarson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnaudBarre ArnaudBarre ArnaudBarre left review comments

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleclarson @patak-dev @ArnaudBarre