-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle namespace import and dynamic import interop consistently #15619
Merged
patak-dev
merged 7 commits into
vitejs:main
from
XiSenao:fix/normalization-of-the-behavior-of-namespaceImport-and-dynamicImport
Jan 18, 2024
Merged
fix: handle namespace import and dynamic import interop consistently #15619
patak-dev
merged 7 commits into
vitejs:main
from
XiSenao:fix/normalization-of-the-behavior-of-namespaceImport-and-dynamicImport
Jan 18, 2024
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n dealing with CommonJS modules.
Run & review this pull request in StackBlitz Codeflow. |
patak-dev
reviewed
Jan 16, 2024
bluwy
reviewed
Jan 16, 2024
patak-dev
reviewed
Jan 16, 2024
patak-dev
reviewed
Jan 16, 2024
patak-dev
previously approved these changes
Jan 16, 2024
XiSenao
changed the title
fix: the abnormal behavior of namespace import and dynamic import when loading commonjs modules
fix: maintain the rationality of interoperation between namespace import and dynamic import.
Jan 18, 2024
bluwy
changed the title
fix: maintain the rationality of interoperation between namespace import and dynamic import.
fix: handle namespace import and dynamic import interop consistently
Jan 18, 2024
bluwy
added
the
p3-minor-bug
An edge case that only affects very specific usage (priority)
label
Jan 18, 2024
bluwy
approved these changes
Jan 18, 2024
/ecosystem-ci run |
📝 Ran ecosystem CI on
|
/ecosystem-ci run |
📝 Ran ecosystem CI on
|
patak-dev
approved these changes
Jan 18, 2024
9 tasks
7 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #15542
fix #15018
Additional context
From the following repository examples:
https://github.com/XiSenao/exceptional-performance-of-loading-commonjs-modules/blob/main/src/main.js
it can be found that using
namespace imports
to loadCommonJS
modules results in inconsistent development and build behaviors. In most cases,dynamic import
behaves as expected. That is to say, it seems effective to rewrite in the following way.However, when exploring how the
@rollup/plugin-commonjs
plugin interacts withrollup
, it seems thatrollup
will merge the transpiledESM
product throughThe logic of the
rollup
processing and the rewrittendynamic import
are somewhat similar, but it can be found that there are still boundary scenarios that will cause inconsistencies between development and build behaviors fordynamic imports
(e.g. only exportArray
orString
).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).