Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preview server add close method #15630

Merged
merged 3 commits into from
Jan 18, 2024
Merged

feat: preview server add close method #15630

merged 3 commits into from
Jan 18, 2024

Conversation

btea
Copy link
Collaborator

@btea btea commented Jan 17, 2024

Description

close #15611

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Jan 17, 2024
View reviewed changes
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jan 17, 2024
ArnaudBarre
ArnaudBarre previously approved these changes Jan 17, 2024
View reviewed changes
packages/vite/src/node/preview.ts Outdated Show resolved Hide resolved
@btea btea dismissed stale reviews from ArnaudBarre and patak-dev via e7db7aa January 18, 2024 01:19
@bluwy bluwy merged commit 947aa53 into vitejs:main Jan 18, 2024
10 checks passed
@btea btea deleted the feat/preview-server-add-close-method branch January 18, 2024 06:59
@bluwy bluwy mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

@ArnaudBarre ArnaudBarre ArnaudBarre left review comments

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a close method for the preview server
4 participants
@btea @patak-dev @ArnaudBarre @bluwy