Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: simplify explicit import mark in import analysis #15724

Merged
merged 1 commit into from
Jan 29, 2024
Merged

perf: simplify explicit import mark in import analysis #15724

merged 1 commit into from
Jan 29, 2024

Conversation

patak-dev
Copy link
Member

Description

We were adding ?import, then running a regex to see if we added it. cleanUp is already called inside isJSRequest too.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the performance Performance related enhancement label Jan 27, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spotting!

@bluwy bluwy merged commit 2805b2d into main Jan 29, 2024
15 checks passed
@bluwy bluwy deleted the perf/mark-explicit-import branch January 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
performance Performance related enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patak-dev @bluwy