-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): runtime HMR affects only imported files #15898
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@patak-dev this can be reviewed. I think it would be nice to have this fix for #15774 (comment) But it does affect the HMR API (adds a property), so I wanted to see what other people think |
/ecosystem-ci run |
📝 Ran ecosystem CI on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bluwy @sapphi-red I leave this one open until tomorrow in case you'd like to check it out before we merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
417c33a
Description
Currently, any
full-reload
event will reload all entrypoints in Vite Runtime. This PR adds atrigger
property to thefull-reload
payload that is used to determine if the file is imported by the entrypoint (or if it's the entrypoint).Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).