feat(optimizer): show a friendly warning with 404 instead of 504 outdated optimize dep

[sapphi-red]

Description

Respond with 404 instead of 504 Outdated optimize dep for files that in dep directory but not handled by Vite.

I set entryNames and chunkNames so that the files Vite expects all have the same prefix __vite-. If a file that doesn't have that prefix is imported, it means it's something that we don't support. In that case, Vite now responds with 404 instead of 504, and shows a warning that a dependency might be incompatible.

close #13506

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines, especially the Pull Request Guidelines.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Update the corresponding documentation if needed.
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 0ac06d1: Open

suite	result	latest scheduled
nx	❌ failure	❌ failure
vite-plugin-svelte	❌ failure	✅ success

✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, qwik, rakkas, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest

[sapphi-red]

plugin-svelte fail is expected. The snapshot needs to be updated because the path of the optimized files are changed.

[bluwy]

I'm not quite sure about this change since the optimized dep directory now looks like .vite/deps/__vite-@foo_bar.js instead of .vite/deps/@foo_bar.js. Mainly only from the stylistic point of view 😅

During esbuild prebundling, we should have a metafile of all output files. Could we match against that instead? .vite/_metadata.json seems to have the list of all file names too.

[sapphi-red]

During esbuild prebundling, we should have a metafile of all output files. Could we match against that instead? .vite/_metadata.json seems to have the list of all file names too.

To do that, we'll have to save the previous _metadata.jsons so that we can know that the request is an outdated one.

We can make the prefix (__vite-) shorter as long as it's sufficiently unique.

[bluwy]

To do that, we'll have to save the previous _metadata.jsons so that we can know that the request is an outdated one.

I'm not sure I understand. Isn't it already handled here?

If I change the check to

          if (metadata.depInfoList.some((dep) => dep.file === file)){
            // Outdated non-entry points (CHUNK), loaded after a rerun
            throwOutdatedRequest(id)
          }
          throwFileNotFoundInOptimizedDep(id)

It seems to work (test passing).

[sapphi-red]

Ah, that's right. I'll update to do it like that.

[bluwy]

Thanks!

[patak-dev]

This looks great!