Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint config #17788

Merged
merged 1 commit into from
Jul 29, 2024
Merged

chore: update eslint config #17788

merged 1 commit into from
Jul 29, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 29, 2024

Description

Supersedes and closes #17769

  • Removes 'regexp/no-contradiction-with-assertion': 'error' as it's already the default.
  • Adds regexp/prefer-regexp-exec and regexp/prefer-regexp-test as they help catch perf improvements. They don't bring up any errors now even though they should because it relies on typechecking which we don't enable in our eslint setup. I'll investigate this as a follow-up PR.
  • Disable lint rules for vite/index.cjs from the eslint config to remove warnings

Copy link

stackblitz bot commented Jul 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@patak-dev patak-dev merged commit 796eef3 into main Jul 29, 2024
11 checks passed
@patak-dev patak-dev deleted the update-eslint-config branch July 29, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants