Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destroy the runner when runnable environment is closed #18282

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

sheremet-va
Copy link
Member

Description

Disallow importing modules in SSR after the environment has been closed (called when server is closed)

@sheremet-va sheremet-va added the feat: environment API Vite Environment API label Oct 4, 2024
Copy link

stackblitz bot commented Oct 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sheremet-va sheremet-va changed the title fix(vite): destroy the runner when runnable environment is closed fix: destroy the runner when runnable environment is closed Oct 4, 2024
@patak-dev patak-dev merged commit 5212d09 into vitejs:main Oct 7, 2024
13 checks passed
@sheremet-va sheremet-va deleted the fix/destory-runner-runnable-env branch October 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: environment API Vite Environment API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants