Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution allows extension-less import which is not aligned with package exports field #18300

Open
7 tasks done
hi-ogawa opened this issue Oct 8, 2024 · 1 comment
Open
7 tasks done

Comments

@hi-ogawa
Copy link
Collaborator

hi-ogawa commented Oct 8, 2024

Describe the bug

Related: #18290

For a package with following files:

  • package.json
{
  "name": "test-dep",
  "private": true,
  "type": "module",
  "exports": {
    "./*": "./*"
  }
}
  • bad.js
export default {}

Vite resolves import "test-dep/bad" to /path-to/bad.js.

Though it's likely that such exports map is not common and probably users wrote it unintended, Vite should probably handle this strictly to avoid confusion with other tools.

Reproduction

https://stackblitz.com/github/hi-ogawa/reproductions/tree/main/vite-exports-resolve-auto-extension?file=README.md

Steps to reproduce

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    vite: latest => 5.4.8

Used Package Manager

pnpm

Logs

No response

Validations

@hi-ogawa hi-ogawa changed the title Resolution allows extension-less import which is not aligned with exports Resolution allows extension-less import which is not aligned with package exports field Oct 8, 2024
@sapphi-red
Copy link
Member

enhanced-resolve and oxc-resolver supports this too, so probably Webpack and rspack supports this.
https://stackblitz.com/edit/github-dymfdy?file=webpack.js,oxc.js

esbuild seems to error for this case (repro).

If we fix this, I guess we can add module-sync condition to the default conditions. (related: https://x.com/JoyeeCheung/status/1843346705200353631)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants