Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): externalize rollup.external scripts correctly #18618

Conversation

sapphi-red
Copy link
Member

Description

This PR fixes two bugs:

  • <script type="module"> with the src externalized by rollupOptions.external was throwing an error (it didn't error before fix: set scripts imported by HTML moduleSideEffects=true #18411)
    • this fix should fix storybook in ecosystem-ci
  • <script type="module"> with the src externalized by rollupOptions.external was not preserved in the output HTML
    • I found this when I wrote the test

@sapphi-red sapphi-red added feat: html p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Nov 8, 2024
@sapphi-red sapphi-red added this to the 6.0 milestone Nov 8, 2024
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 7eea400: Open

suite result latest scheduled
astro failure failure
histoire failure failure
marko failure failure
redwoodjs failure failure
remix failure failure
storybook success failure
sveltekit failure failure
vike failure failure
vite-plugin-react failure failure
vite-plugin-svelte failure failure
vite-plugin-vue success failure
vitest failure failure

analogjs, ladle, laravel, nuxt, previewjs, quasar, qwik, rakkas, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react-swc, vite-setup-catalogue, vitepress, vuepress

@patak-dev patak-dev merged commit 55461b4 into vitejs:main Nov 9, 2024
18 checks passed
@sapphi-red sapphi-red deleted the fix/html-externalize-rollup-external-scripts branch November 11, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants