Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite module runner has been closed #18962

Closed
7 tasks done
DanOfir opened this issue Dec 14, 2024 · 0 comments · Fixed by #18973
Closed
7 tasks done

Vite module runner has been closed #18962

DanOfir opened this issue Dec 14, 2024 · 0 comments · Fixed by #18973
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release

Comments

@DanOfir
Copy link

DanOfir commented Dec 14, 2024

Describe the bug

After upgrading to version 6, a hot reload in the development environment leads to a server crash without recovery.

Reproduction

vite.new

Steps to reproduce

  1. running the sever locally using: pnpm remix vite:dev
  2. go to any path for example /health -> should return OK
  3. trigger save in vite.config.ts -> should trigger server restart ([vite] server restarted)
  4. go to any path again /health , now it will return 500 with an error "Vite module runner has been closed"

revert to Vite 5.4.11 to fix the issue.

System Info

System:
    OS: macOS 15.1.1
    CPU: (12) arm64 Apple M4 Pro
    Memory: 1.01 GB / 48.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - ~/.nvm/versions/node/v22.11.0/bin/node
    npm: 10.9.0 - ~/.nvm/versions/node/v22.11.0/bin/npm
    pnpm: 9.15.0 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 131.0.6778.140
    Safari: 18.1.1
  npmPackages:
    vite: ^6.0.3 => 6.0.3

Used Package Manager

pnpm

Logs

Error: Vite module runner has been closed.
at SSRCompatModuleRunner.getModuleInformation (file:///app/node_modules/.pnpm/vite@6.0.3_@types+node@20.17.6_jiti@1.21.6_sass@1.80.6_terser@5.36.0_tsx@4.19.2_yaml@2.6.0/node_modules/vite/dist/node/module-runner.js:1196:13)
at SSRCompatModuleRunner.cachedModule (file:///app/node_modules/.pnpm/vite@6.0.3_@types+node@20.17.6_jiti@1.21.6_sass@1.80.6_terser@5.36.0_tsx@4.19.2_yaml@2.6.0/node_modules/vite/dist/node/module-runner.js:1186:21)
at SSRCompatModuleRunner.import (file:///app/node_modules/.pnpm/vite@6.0.3_@types+node@20.17.6_jiti@1.21.6_sass@1.80.6_terser@5.36.0_tsx@4.19.2_yaml@2.6.0/node_modules/vite/dist/node/module-runner.js:1110:38)
at instantiateModule (file:///app/node_modules/.pnpm/vite@6.0.3_@types+node@20.17.6_jiti@1.21.6_sass@1.80.6_terser@5.36.0_tsx@4.19.2_yaml@2.6.0/node_modules/vite/dist/node/chunks/dep-yUJfKD1i.js:30569:31)
at requestHandler (/app/node_modules/.pnpm/@remix-run+server-runtime@2.15.0_typescript@5.6.3/node_modules/@remix-run/server-runtime/dist/server.js:65:44)
at /app/node_modules/.pnpm/@remix-run+express@2.15.0_express@4.21.1_typescript@5.6.3/node_modules/@remix-run/express/dist/server.js:41:22

Validations

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr regression The issue only appears after a new release labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants