Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): register inlined assets as a dependency of CSS file #18979

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

sapphi-red
Copy link
Member

Description

This PR fixes #18963 by registering inlined assets as a dependency of CSS files.

fixes #18963
alternative to #18972 (which requires more bigger change)

@sapphi-red sapphi-red added feat: css feat: hmr p4-important Violate documented behavior or significantly improves performance (priority) labels Dec 17, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just to play safe, I think we could merge this one in 6.1, we'll be starting it soon anyways

@sapphi-red sapphi-red merged commit eb22a74 into vitejs:main Jan 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css feat: hmr p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inlined SVG is not updated unless the server is restarted
3 participants