Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facadeModuleId error when enabling manifest option with rollup externals #2347

Closed
3 tasks done
elwynelwyn opened this issue Mar 3, 2021 · 1 comment · Fixed by #2353 or #2532
Closed
3 tasks done

facadeModuleId error when enabling manifest option with rollup externals #2347

elwynelwyn opened this issue Mar 3, 2021 · 1 comment · Fixed by #2353 or #2532

Comments

@elwynelwyn
Copy link

⚠️ IMPORTANT ⚠️ Please do not ignore this template. If you do, your issue will be closed immediately.

Describe the bug

When enabling the build.manifest option alongside the build.rollupOptions.external option an error is thrown when building

Reproduction

https://github.com/elwynelwyn/vite-manifest-with-externals

System Info

  • vite version: 2.0.5
  • Operating System: debian
  • Node version: 12.14.1
  • Package manager (npm/yarn/pnpm) and version: yarn@1.22.4

Logs (Optional if provided reproduction)

yarn build
yarn run v1.22.4
warning package.json: No license field
$ tsc && vite build
vite v2.0.5 building for production...
✓ 7 modules transformed.
rendering chunks (1)...

error during build:
TypeError: Cannot read property 'facadeModuleId' of undefined
    at getChunkName (/repos/vite-manifest-with-externals/node_modules/vite/dist/node/chunks/dep-e0f09032.js:26966:27)
    at /repos/vite-manifest-with-externals/node_modules/vite/dist/node/chunks/dep-e0f09032.js:26992:73
    at Array.map (<anonymous>)
    at createChunk (/repos/vite-manifest-with-externals/node_modules/vite/dist/node/chunks/dep-e0f09032.js:26992:59)
    at Object.generateBundle (/repos/vite-manifest-with-externals/node_modules/vite/dist/node/chunks/dep-e0f09032.js:27009:53)
    at /repos/vite-manifest-with-externals/node_modules/rollup/dist/shared/rollup.js:19049:25
error Command failed with exit code 1.

Note this is the same issue as #2006 which was closed due to no repro

@MinJieLiu
Copy link

still error

[vite:manifest] Cannot read property 'facadeModuleId' of undefined

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants