fix(plugin-react): uncompiled JSX in linked pkgs #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
added
p5-urgent
aleclarson
force-pushed
the
fix/react-2
branch
from
e13a27d
to
da05ffd
Compare
patak-dev
approved these changes
Nov 13, 2021
patak-dev
changed the title
patak-dev
pushed a commit
that referenced
this pull request
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5642
When a linked package contains a
.jsxor.tsxmodule, we need to apply the JSX transform using Babel. Previously,plugin-reactwould only look for compiled JSX within.jsxand.tsxmodules (if they weren't within the project root) to decide if the Babel JSX transform should be applied.