Working directly with html files doesn't provide the best developer experience #6175
Closed
7 tasks done
Labels
Comments
|
After playing around with this issue i have a solution but im not sure of the implications across other areas of vite. in the error middleware instead of just calling res.end(`
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<title>Error</title>
<script type="module">
import { ErrorOverlay } from '/@vite/client'
document.body.appendChild(new ErrorOverlay(${JSON.stringify(prepareError(err)).replace(/</g, '\\u003c')}))
</script>
</head>
<body>
</body>
</html>
`)vite.html.reload.fix.mp4 |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
When working with html files saving them in a invalid state causes the browsers to do a page reload and receives a 500 response code defaulting to the browsers error page. when you fix the html file the browser requires a manually refresh from the user.
when you return back to the browser a error overlay will show with error that should of been shown when the invalid index.html was first parsed
Reproduction
vite.html.reload.mp4
System Info
System: OS: Linux 5.10 Ubuntu 20.04.2 LTS (Focal Fossa) CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor Memory: 21.29 GB / 25.01 GB Container: Yes Shell: 5.8 - /usr/bin/zsh Binaries: Node: 16.13.1 - ~/.volta/tools/image/node/16.13.1/bin/node Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn npm: 8.1.2 - ~/.volta/tools/image/node/16.13.1/bin/npmUsed Package Manager
yarn
Logs
No response
Validations
The text was updated successfully, but these errors were encountered: