error when starting dev server on v2.7.11

[konstantin24121]

Describe the bug

Just upgraded to v2.7.11, on previous 2.7.10 all starts fine

Reproduction

need reproduction

System Info

System:
    OS: macOS 12.0
    CPU: (8) arm64 Apple M1
    Memory: 79.16 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.8.0 - ~/.nvm/versions/node/v16.8.0/bin/node
    Yarn: 3.1.0 - ~/.nvm/versions/node/v16.8.0/bin/yarn
    npm: 7.21.0 - ~/.nvm/versions/node/v16.8.0/bin/npm
    Watchman: 2021.12.20.00 - /usr/local/bin/watchman
  Browsers:
    Chrome: 97.0.4692.71
    Firefox: 88.0.1
    Safari: 15.0
  npmPackages:
    @vitejs/plugin-react: ^1.1.4 => 1.1.4 
    vite: 2.7.11 => 2.7.11

Used Package Manager

yarn

Logs

error when starting dev server:
TypeError: Cannot read property 'replace' of undefined
    at normalizeId$1 (/node_modules/vite/dist/node/chunks/dep-48c3e8a4.js:3879:34)
    at optimizeDeps (/node_modules/vite/dist/node/chunks/dep-48c3e8a4.js:56534:34)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async runOptimize (/vite/dist/node/chunks/dep-48c3e8a4.js:60540:48)
    at async Http2SecureServer.httpServer.listen (/node_modules/vite/dist/node/chunks/dep-48c3e8a4.js:60556:21)

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[github-actions]

Hello @konstantin24121. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

[giorginogreg]

Same here, i've started an open source project here, simply run npm run dev, that started slidev, a third part dependency that uses vite (latest version, so v2.7.11), and has this error.

System:
OS: macOS 12.1
CPU: (8) arm64 Apple M1
Memory: 8.00 GB
Shell: 5.8 - /bin/zsh

Also tried v2.7.10 of vite, same issue.

[patak-dev]

@giorginogreg please create a new issue with your reproduction. The original said that it worked in 2.7.10 so it seems you are hitting a different regression. Thanks!

[akhilmhdh]

Yup. Just bumped into this issue now, was trying out vite for first time. Needed to install commonjs plugin.

And by that example, i needed to add plugin in optimizeDeps.esbuildOptions.plugins. But was getting the error.

error when starting dev server:
TypeError: Cannot read property 'replace' of undefined
    at normalizeId$1 (/Users/akhilmhdh/Akhi/one-platform/packages/feedback-spa/node_modules/vite/dist/node/chunks/dep-48c3e8a4.js:3879:34)
    at optimizeDeps (/Users/akhilmhdh/Akhi/one-platform/packages/feedback-spa/node_modules/vite/dist/node/chunks/dep-48c3e8a4.js:56534:34)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async runOptimize (/Users/akhilmhdh/Akhi/one-platform/packages/feedback-spa/node_modules/vite/dist/node/chunks/dep-48c3e8a4.js:60540:48)
    at async Server.httpServer.listen (/Users/akhilmhdh/Akhi/one-platform/packages/feedback-spa/node_modules/vite/dist/node/chunks/dep-48c3e8a4.js:60556:21)

Then i just applied without any plugin and noticed that, its firing only when plugins is used inside esbuildOptions even as empty array.

Here is my config file

import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import legacy from '@vitejs/plugin-legacy';
import { viteCommonjs, esbuildCommonjs } from '@originjs/vite-plugin-commonjs';

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [
    viteCommonjs(),
    legacy({
      targets: ['defaults', 'not IE 11'],
    }),
    react(),
  ],
  optimizeDeps: {
    esbuildOptions: {
      plugins: [esbuildCommonjs(['@patternfly/react-styles'])],
    },
  },
});

Downgraded to v2.7.0, and walla works perfectly. So some issue with v2.7.2 i think so.

To reproduce

1. Create a react app using vite cli
2. Just create an empty array inside optimizeDeps.esbuildOptions.plugins

This one created frustration hell in me 😅

[recih]

Has same issue here.
After some investigation, it caused by a bug in mergeConfigRecursively when merging array values, which has been fixed in #6499

Workaround can be used before new version released:

optimizeDeps: {
  ...
  include: []    // add this
}

[Niputi]

@recih change is in 2.7.12