-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-legacy): always fallback legacy build when CSP #6535
Conversation
We experience the same issue. Thanks for this PR! |
Same here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Could consider adding it back when vitejs/vite#6535 is merged
@sodatea Any chance pushing this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the environment to test it.
But the code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. Such a cool trick, thanks for the PR!
Description
Fixed #5919
Additional context
I use this answer to solve the problem of detecting dynamic imports needing
eval
.Another answer also looks great, but we need a new file or allow
data:
in CSP, so I use the top answer.You can use this project for test PR.
https://github.com/yoyo930021/vite-legacy-csp-bug
I test it in Edge 16, Edge 17, Edge 18, Chrome 62 with browserstack.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).