Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-vite): supports nested directory (closes #6638) #6739

Merged
merged 1 commit into from
May 10, 2022
Merged

feat(create-vite): supports nested directory (closes #6638) #6739

merged 1 commit into from
May 10, 2022

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Feb 3, 2022

closes #6638

Description

For example, @foo/bar, as project name

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 4, 2022
@patak-dev patak-dev changed the title feat(create-vite): supports nested directory feat(create-vite): supports nested directory (closes #6638) May 10, 2022
@patak-dev patak-dev merged commit 6ccf9aa into vitejs:main May 10, 2022
@pd4d10 pd4d10 deleted the patch-3 branch May 10, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The project doesn't init when the project name contains an "@"
3 participants
@pd4d10 @patak-dev @bluwy